Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/tracing.gyp

Issue 1298683002: Convert components/tracing from static lib to component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/tracing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing.gyp
diff --git a/components/tracing.gyp b/components/tracing.gyp
index 7857830c16737b3bb09490e617b316968ede8304..32b1bb7142c19ecfdbc473744f3f741bf975cce1 100644
--- a/components/tracing.gyp
+++ b/components/tracing.gyp
@@ -14,7 +14,7 @@
'targets' : [
{
'target_name': 'tracing',
- 'type': 'static_library',
+ 'type': '<(component)',
'dependencies': [
'../base/base.gyp:base',
'../ipc/ipc.gyp:ipc',
@@ -22,11 +22,15 @@
'include_dirs': [
'..',
],
+ 'defines': [
+ 'TRACING_IMPLEMENTATION=1',
+ ],
'sources': [
'tracing/child_memory_dump_manager_delegate_impl.cc',
'tracing/child_memory_dump_manager_delegate_impl.h',
'tracing/child_trace_message_filter.cc',
'tracing/child_trace_message_filter.h',
+ 'tracing/tracing_export.h',
'tracing/startup_tracing.cc',
'tracing/startup_tracing.h',
'tracing/tracing_messages.cc',
« no previous file with comments | « no previous file | components/tracing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698