Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298543002: DevTools: Support Top-Down tree view on Timeline (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
caseq, yurys, paulirish
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Support Top-Down tree view on Timeline BUG=463547 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200704

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -76 lines) Patch
M Source/devtools/front_end/timeline/TimelineModel.js View 1 2 chunks +25 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineTreeView.js View 1 4 chunks +132 lines, -74 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
alph
5 years, 4 months ago (2015-08-15 01:45:04 UTC) #2
caseq
lgtm https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode214 Source/devtools/front_end/timeline/TimelineTreeView.js:214: for (var child of topDown.children.values()) { Can we ...
5 years, 4 months ago (2015-08-17 21:50:53 UTC) #3
caseq
https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode185 Source/devtools/front_end/timeline/TimelineTreeView.js:185: var nonessentialEvents = new Set([ Also, please extract this ...
5 years, 4 months ago (2015-08-17 21:53:05 UTC) #4
alph
ptal https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1298543002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode185 Source/devtools/front_end/timeline/TimelineTreeView.js:185: var nonessentialEvents = new Set([ On 2015/08/17 21:53:05, ...
5 years, 4 months ago (2015-08-17 23:25:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298543002/20001
5 years, 4 months ago (2015-08-17 23:31:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99396)
5 years, 4 months ago (2015-08-18 02:05:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298543002/20001
5 years, 4 months ago (2015-08-18 04:02:12 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:44:34 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200704

Powered by Google App Engine
This is Rietveld 408576698