Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1298543002: DevTools: Support Top-Down tree view on Timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressing comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index 51722814e375deeec817ce15a3a07a02d1a79e47..6919c5a1fee55818ca5ef3c944d8c5072b033657 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -1555,7 +1555,7 @@ WebInspector.TimelineModel.buildTopDownTree = function(events, startTime, endTim
/**
* @param {!WebInspector.TimelineModel.ProfileTreeNode} topDownTree
- * @param {function(!WebInspector.TimelineModel.ProfileTreeNode):?WebInspector.TimelineModel.ProfileTreeNode=} groupingCallback
+ * @param {?function(!WebInspector.TimelineModel.ProfileTreeNode):!WebInspector.TimelineModel.ProfileTreeNode=} groupingCallback
* @return {!WebInspector.TimelineModel.ProfileTreeNode}
*/
WebInspector.TimelineModel.buildBottomUpTree = function(topDownTree, groupingCallback)
@@ -1835,6 +1835,30 @@ WebInspector.InclusiveTraceEventNameFilter.prototype = {
/**
* @constructor
+ * @extends {WebInspector.TraceEventNameFilter}
+ * @param {!Array<string>} excludeNames
+ */
+WebInspector.ExclusiveTraceEventNameFilter = function(excludeNames)
+{
+ WebInspector.TraceEventNameFilter.call(this, excludeNames);
+}
+
+WebInspector.ExclusiveTraceEventNameFilter.prototype = {
+ /**
+ * @override
+ * @param {!WebInspector.TracingModel.Event} event
+ * @return {boolean}
+ */
+ accept: function(event)
+ {
+ return !this._eventNames[event.name];
+ },
+
+ __proto__: WebInspector.TraceEventNameFilter.prototype
+}
+
+/**
+ * @constructor
* @implements {WebInspector.TraceEventFilter}
*/
WebInspector.ExcludeTopLevelFilter = function()
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698