chrome/browser/ui/views/toolbar/toolbar_button.h - Issue 1298513003: Implemented prototype for new ink drop specs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1298513003: Implemented prototype for new ink drop specs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed outstanding concerns and improved documentation. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_button.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.h b/chrome/browser/ui/views/toolbar/toolbar_button.h

index c61d85cb07d293772c90469ebdd48de66cf8d1c3..1a48f7e2d5dcb1f5767756cfa20e801858dcc86a 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.h

@@ -68,6 +68,9 @@ class ToolbarButton : public views::LabelButton,

// to the PUSHED state.

bool ShouldEnterPushedState(const ui::Event& event) override;

+ // views::LabelButton:

+ void NotifyClick(const ui::Event& event) override;

Peter Kasting 2015/09/03 21:53:06 Nit: No subclasses need to call this, so make this

bruthig 2015/09/09 18:00:36 Incorrect, HomeButton::OnNotifyClick() calls Toolb

// Returns if menu should be shown. Override this to change default behavior.

virtual bool ShouldShowMenu();