Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4788)

Unified Diff: chrome/browser/ui/views/toolbar/back_button.cc

Issue 1298513003: Implemented prototype for new ink drop specs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed outstanding concerns and improved documentation. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/back_button.cc
diff --git a/chrome/browser/ui/views/toolbar/back_button.cc b/chrome/browser/ui/views/toolbar/back_button.cc
index 73ae0411c64c06f374cbaab0be52536da6b57451..eaf4310c698b258b2014f968f45ec798603b5106 100644
--- a/chrome/browser/ui/views/toolbar/back_button.cc
+++ b/chrome/browser/ui/views/toolbar/back_button.cc
@@ -33,8 +33,9 @@ void BackButton::SetLeadingMargin(int margin) {
}
void BackButton::LayoutInkDrop() {
- ink_drop_animation_controller()->SetInkDropBounds(
- gfx::Rect(margin_leading_, 0, width() - margin_leading_, height()));
+ ToolbarButton::LayoutInkDrop();
Peter Kasting 2015/09/03 21:53:06 As a reader I'm unsure whether this line has to be
bruthig 2015/09/09 18:00:35 I've re-worked this a little bit. FTR the ordering
+ ink_drop_animation_controller()->SetInkDropCenter(gfx::Point(
+ (width() - margin_leading_) / 2 + margin_leading_, height() / 2));
Peter Kasting 2015/09/03 21:53:06 Nit: Seems like you can just do (width() + margin_
bruthig 2015/09/09 18:00:35 Done.
}
const char* BackButton::GetClassName() const {

Powered by Google App Engine
This is Rietveld 408576698