Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298503003: DevTools: fix control flow in OverridesSupport.setDeviceMetricsOverride (Closed)

Created:
5 years, 4 months ago by lushnikov
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@throttler
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix control flow in OverridesSupport.setDeviceMetricsOverride R=dgozman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M Source/devtools/front_end/emulation/OverridesSupport.js View 1 chunk +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1285183006 Patch 20001

Messages

Total messages: 9 (3 generated)
lushnikov
ptal
5 years, 4 months ago (2015-08-14 21:22:41 UTC) #1
dgozman
lgtm
5 years, 4 months ago (2015-08-14 23:50:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298503003/1
5 years, 4 months ago (2015-08-15 00:47:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/99239)
5 years, 4 months ago (2015-08-15 00:50:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298503003/1
5 years, 4 months ago (2015-08-15 05:24:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 05:49:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200600

Powered by Google App Engine
This is Rietveld 408576698