Source/web/tests/ScrollingCoordinatorTest.cpp - Issue 1298493003: Currently we only composite fixed position elements if we are on High DPI devices. This fix allows …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 1298493003: Currently we only composite fixed position elements if we are on High DPI devices. This fix allows … Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove similarity check Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/compositing/CompositingReasonFinder.cpp ('K') | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | Source/web/tests/data/fixed-position-losing-backing.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/tests/ScrollingCoordinatorTest.cpp

diff --git a/Source/web/tests/ScrollingCoordinatorTest.cpp b/Source/web/tests/ScrollingCoordinatorTest.cpp

index 977730e95a853edd816815e2888f7cc2fe0ef6c6..ea484fac895cf87c962960935079fd85f8f9f2e9 100644

--- a/Source/web/tests/ScrollingCoordinatorTest.cpp

+++ b/Source/web/tests/ScrollingCoordinatorTest.cpp

@@ -595,13 +595,13 @@ TEST_F(ScrollingCoordinatorTest, FixedPositionLosingBackingShouldTriggerMainThre

Document* document = frame()->document();

Element* fixedPos = document->getElementById("fixed");

- EXPECT_TRUE(static_cast<LayoutBoxModelObject*>(fixedPos->layoutObject())->layer()->hasCompositedDeprecatedPaintLayerMapping());

+ ASSERT_EQ(PaintsIntoOwnBacking, static_cast<LayoutBoxModelObject*>(fixedPos->layoutObject())->layer()->compositingState());

EXPECT_FALSE(scrollLayer->shouldScrollOnMainThread());

- fixedPos->setInlineStyleProperty(CSSPropertyTransform, CSSValueNone);

+ fixedPos->setInlineStyleProperty(CSSPropertyBackground, "rgba(255, 255, 0, 0.99)");

forceFullCompositingUpdate();

- EXPECT_FALSE(static_cast<LayoutBoxModelObject*>(fixedPos->layoutObject())->layer()->hasCompositedDeprecatedPaintLayerMapping());

+ ASSERT_EQ(NotComposited, static_cast<LayoutBoxModelObject*>(fixedPos->layoutObject())->layer()->compositingState());

EXPECT_TRUE(scrollLayer->shouldScrollOnMainThread());

}