[Chromecast] Moves persistent UMA client ID handling to common code.

chromecast/browser/metrics/cast_metrics_service_client.h

Index: chromecast/browser/metrics/cast_metrics_service_client.h
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h
index 771b78edb02f0342c74472705700cd83755190b5..98b736a1526ac4bc1c57e0b6e51543b01285973f 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.h
+++ b/chromecast/browser/metrics/cast_metrics_service_client.h
@@ -48,6 +48,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
       net::URLRequestContextGetter* request_context);
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
+  void SetPersistedClientId(const std::string& client_id);

[halliwell, 2015/08/19 13:25:17]

nit: persistent

[gunsch, 2015/08/19 15:34:46]

I'm not sure I agree, actually. "SetPersistentClientId" to me implies that it
should be stored/persisted. This method is for providing a previously-persisted
client ID to CastMetricsServiceClient.

But I'm open to other reasons or other name suggestions, too. I wasn't the
happiest with this name.

[halliwell, 2015/08/19 20:56:18]

I see, thanks for explanation.

   void Initialize(CastService* cast_service);
   void Finalize();
 
@@ -87,6 +88,8 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
   PrefService* const pref_service_;
   CastService* cast_service_;
   std::string client_id_;
+  std::string platform_client_id_;

[gfhuang, 2015/08/19 15:48:27]

persisted_client_id_

[gunsch, 2015/08/19 15:52:50]

Done.

+  bool client_info_loaded_;
 
 #if defined(OS_LINUX)
   ExternalMetrics* external_metrics_;