[Chromecast] Moves persistent UMA client ID handling to common code.

chromecast/browser/metrics/cast_metrics_service_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_BROWSER_METRICS_CAST_METRICS_SERVICE_CLIENT_H_
 #define CHROMECAST_BROWSER_METRICS_CAST_METRICS_SERVICE_CLIENT_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 30 matching lines @@
 class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
  public:
   ~CastMetricsServiceClient() override;
 
   static scoped_ptr<CastMetricsServiceClient> Create(
       base::TaskRunner* io_task_runner,
       PrefService* pref_service,
       net::URLRequestContextGetter* request_context);
   static void RegisterPrefs(PrefRegistrySimple* registry);
 
+  void SetPersistedClientId(const std::string& client_id);

[halliwell, 2015/08/19 13:25:17]

nit: persistent

[gunsch, 2015/08/19 15:34:46]

I'm not sure I agree, actually. "SetPersistentClientId" to me implies that it
should be stored/persisted. This method is for providing a previously-persisted
client ID to CastMetricsServiceClient.

But I'm open to other reasons or other name suggestions, too. I wasn't the
happiest with this name.

[halliwell, 2015/08/19 20:56:18]

I see, thanks for explanation.

   void Initialize(CastService* cast_service);
   void Finalize();
 
   // metrics::MetricsServiceClient implementation:
   void SetMetricsClientId(const std::string& client_id) override;
   void OnRecordingDisabled() override;
   bool IsOffTheRecordSessionActive() override;
   int32_t GetProduct() override;
   std::string GetApplicationLocale() override;
   bool GetBrand(std::string* brand_code) override;
@@ skipping 19 matching lines @@
   // Returns whether or not metrics reporting is enabled.
   bool IsReportingEnabled();
 
   scoped_ptr< ::metrics::ClientInfo> LoadClientInfo();
   void StoreClientInfo(const ::metrics::ClientInfo& client_info);
 
   base::TaskRunner* const io_task_runner_;
   PrefService* const pref_service_;
   CastService* cast_service_;
   std::string client_id_;
+  std::string platform_client_id_;

[gfhuang, 2015/08/19 15:48:27]

persisted_client_id_

[gunsch, 2015/08/19 15:52:50]

Done.

+  bool client_info_loaded_;
 
 #if defined(OS_LINUX)
   ExternalMetrics* external_metrics_;
   ExternalMetrics* platform_metrics_;
 #endif  // defined(OS_LINUX)
   const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
   scoped_ptr< ::metrics::MetricsStateManager> metrics_state_manager_;
   scoped_ptr< ::metrics::MetricsService> metrics_service_;
   net::URLRequestContextGetter* const request_context_;
 
   DISALLOW_COPY_AND_ASSIGN(CastMetricsServiceClient);
 };
 
 }  // namespace metrics
 }  // namespace chromecast
 
 #endif  // CHROMECAST_BROWSER_METRICS_CAST_METRICS_SERVICE_CLIENT_H_