Issue 1298423005: prod: fix timezone conversion from AppEngine layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1298423005: prod: fix timezone conversion from AppEngine layer (Closed)

Created:
5 years, 4 months ago by dnj

Modified:
5 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews

Base URL:
https://github.com/luci/gae@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

prod: fix timezone conversion from AppEngine layer R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/45571ff0590a3c43200cd179d7e9bbd1a19c50a2

Patch Set 1 #

Total comments: 2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	impl/prod/raw_datastore_type_converter.go	View		2 chunks	+5 lines, -0 lines	1 comment	Download
	M	service/datastore/properties.go	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/1298423005/diff/1/impl/prod/raw_datastore_type_converter.go File impl/prod/raw_datastore_type_converter.go (right): https://codereview.chromium.org/1298423005/diff/1/impl/prod/raw_datastore_type_converter.go#newcode36 impl/prod/raw_datastore_type_converter.go:36: // "appengine" layer instantiates with Local timezone. seriously ...

5 years, 4 months ago (2015-08-19 21:55:26 UTC) #2

dnj

5 years, 4 months ago (2015-08-19 22:41:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45571ff0590a3c43200cd179d7e9bbd1a19c50a2 (presubmit successful).

Expand Messages | Collapse Messages