service/datastore/properties.go - Issue 1298423005: prod: fix timezone conversion from AppEngine layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/properties.go

Issue 1298423005: prod: fix timezone conversion from AppEngine layer (Closed) Base URL: https://github.com/luci/gae@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/properties.go

diff --git a/service/datastore/properties.go b/service/datastore/properties.go

index 44a4361ed895051e1516fb364d810027acfb0952..63156fe68da97b5f7ddf9f4c4600aa2c53861d49 100644

--- a/service/datastore/properties.go

+++ b/service/datastore/properties.go

@@ -209,7 +209,7 @@ func PropertyTypeOf(v interface{}, checkValid bool) (PropertyType, error) {

err = errors.New("time value out of range")

}

if checkValid && !timeLocationIsUTC(x.Location()) {

- err = fmt.Errorf("time value has wrong Location: %v %v", x.Location())

iannucci 2015/08/19 21:55:26 cool, I was gonna fix this in my next CL :)

+ err = fmt.Errorf("time value has wrong Location: %v", x.Location())

}

return PTTime, err

case GeoPoint: