core/include/fxge/fx_font.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxge/fx_font.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Stray file. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxge/fx_font.h

diff --git a/core/include/fxge/fx_font.h b/core/include/fxge/fx_font.h

index 1423be497b2bf706a419750eb0a45d5e4e78a3f4..c91036fad76df26055eb8b1ea635136b83f9ec6b 100644

--- a/core/include/fxge/fx_font.h

+++ b/core/include/fxge/fx_font.h

@@ -436,4 +436,6 @@ class IFX_GSUBTable {

virtual ~IFX_GSUBTable() {}

};

+CFX_ByteString FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name);

Lei Zhang 2015/08/19 19:31:14 FPDF_Foo() is usually a public API. Omit the "FPDF

Tom Sepez 2015/08/19 20:25:34 Done. https://code.google.com/p/chromium/codesear

#endif // CORE_INCLUDE_FXGE_FX_FONT_H_