Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1298253003: Merge the multiple frame tree walks in PageAnimator::serviceScriptedAnimations. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
ojan, Sami, dglazkov
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge the multiple frame tree walks in PageAnimator::serviceScriptedAnimations. There's no real reason to do all this work in multiple passes over the Vector of Documents. This change does alter the web exposed behavior slightly since now given two same origin iframes that are siblings in the frame tree: A / \ B C when B runs if it looks at C's scroll position during a scroll animation and SMIL animation state it may see slightly different results, especially if the B frame actually started the animation in the C frame. This is already very racing and unpredictable in browsers since it's an obscure edge case, so I'm not too worried it'll break content. This will allow easily skipping iframes that are still loading when processing the blink pipeline. BUG=521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M Source/core/page/PageAnimator.cpp View 2 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298253003/1
5 years, 4 months ago (2015-08-18 21:05:39 UTC) #2
esprehn
5 years, 4 months ago (2015-08-18 21:59:55 UTC) #4
ojan
lgtm
5 years, 4 months ago (2015-08-18 22:01:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298253003/1
5 years, 4 months ago (2015-08-18 22:10:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 22:42:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200761

Powered by Google App Engine
This is Rietveld 408576698