Merge the multiple frame tree walks in PageAnimator::serviceScriptedAnimations.

Source/core/page/PageAnimator.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/page/PageAnimator.h"
 
 #include "core/animation/DocumentAnimations.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 25 matching lines @@
 {
     RefPtrWillBeRawPtr<PageAnimator> protector(this);
     TemporaryChange<bool> servicing(m_servicingAnimations, true);
 
     WillBeHeapVector<RefPtrWillBeMember<Document>> documents;
     for (Frame* frame = m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
         if (frame->isLocalFrame())
             documents.append(toLocalFrame(frame)->document());
     }
 
-    for (size_t i = 0; i < documents.size(); ++i) {
-        if (documents[i]->view()) {
-            documents[i]->view()->scrollableArea()->serviceScrollAnimations(monotonicAnimationStartTime);
+    for (auto& document : documents) {
+        if (document->view()) {
+            document->view()->scrollableArea()->serviceScrollAnimations(monotonicAnimationStartTime);
 
-            if (const FrameView::ScrollableAreaSet* animatingScrollableAreas = documents[i]->view()->animatingScrollableAreas()) {
+            if (const FrameView::ScrollableAreaSet* animatingScrollableAreas = document->view()->animatingScrollableAreas()) {
                 // Iterate over a copy, since ScrollableAreas may deregister
                 // themselves during the iteration.
                 Vector<ScrollableArea*> animatingScrollableAreasCopy;
                 copyToVector(*animatingScrollableAreas, animatingScrollableAreasCopy);
                 for (ScrollableArea* scrollableArea : animatingScrollableAreasCopy)
                     scrollableArea->serviceScrollAnimations(monotonicAnimationStartTime);
             }
         }
+        DocumentAnimations::updateAnimationTimingForAnimationFrame(*document, monotonicAnimationStartTime);
+        SVGDocumentExtensions::serviceOnAnimationFrame(*document, monotonicAnimationStartTime);
+        document->serviceScriptedAnimations(monotonicAnimationStartTime);
     }
 
-    for (size_t i = 0; i < documents.size(); ++i) {
-        DocumentAnimations::updateAnimationTimingForAnimationFrame(*documents[i], monotonicAnimationStartTime);
-        SVGDocumentExtensions::serviceOnAnimationFrame(*documents[i], monotonicAnimationStartTime);
-    }
-
-    for (size_t i = 0; i < documents.size(); ++i)
-        documents[i]->serviceScriptedAnimations(monotonicAnimationStartTime);
-
 #if ENABLE(OILPAN)
+    // TODO(esprehn): Why is this here? It doesn't make sense to explicitly
+    // clear a stack allocated vector.
     documents.clear();
 #endif
 }
 
 void PageAnimator::scheduleVisualUpdate(LocalFrame* frame)
 {
     if (m_servicingAnimations || m_updatingLayoutAndStyleForPainting)
         return;
     // FIXME: The frame-specific version of scheduleAnimation() is for
     // out-of-process iframes. Passing 0 or the top-level frame to this method
@@ skipping 11 matching lines @@
     RefPtrWillBeRawPtr<FrameView> view = rootFrame->view();
 
     TemporaryChange<bool> servicing(m_updatingLayoutAndStyleForPainting, true);
 
     // setFrameRect may have the side-effect of causing existing page layout to
     // be invalidated, so layout needs to be called last.
     view->updateAllLifecyclePhases();
 }
 
 }