Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2301)

Unified Diff: net/http/http_network_layer.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_layer.h
diff --git a/net/http/http_network_layer.h b/net/http/http_network_layer.h
index 5ade926c3bddbfe123b391770d9a59f7e94bbe92..89ff8eb73d77efcb26b62b8242ff8430d53a4960 100644
--- a/net/http/http_network_layer.h
+++ b/net/http/http_network_layer.h
@@ -26,7 +26,8 @@ class NET_EXPORT HttpNetworkLayer
NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
// Construct a HttpNetworkLayer with an existing HttpNetworkSession which
- // contains a valid ProxyService.
+ // contains a valid ProxyService. The HttpNetworkLayer must be destroyed
+ // before |session|.
explicit HttpNetworkLayer(HttpNetworkSession* session);
~HttpNetworkLayer() override;
@@ -41,7 +42,7 @@ class NET_EXPORT HttpNetworkLayer
void OnResume() override;
private:
- const scoped_refptr<HttpNetworkSession> session_;
+ HttpNetworkSession* const session_;
bool suspended_;
DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer);
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698