Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: net/http/http_network_layer.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_NETWORK_LAYER_H_ 5 #ifndef NET_HTTP_HTTP_NETWORK_LAYER_H_
6 #define NET_HTTP_HTTP_NETWORK_LAYER_H_ 6 #define NET_HTTP_HTTP_NETWORK_LAYER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "base/power_monitor/power_observer.h" 14 #include "base/power_monitor/power_observer.h"
15 #include "base/threading/non_thread_safe.h" 15 #include "base/threading/non_thread_safe.h"
16 #include "net/base/net_export.h" 16 #include "net/base/net_export.h"
17 #include "net/http/http_transaction_factory.h" 17 #include "net/http/http_transaction_factory.h"
18 18
19 namespace net { 19 namespace net {
20 20
21 class HttpNetworkSession; 21 class HttpNetworkSession;
22 22
23 class NET_EXPORT HttpNetworkLayer 23 class NET_EXPORT HttpNetworkLayer
24 : public HttpTransactionFactory, 24 : public HttpTransactionFactory,
25 public base::PowerObserver, 25 public base::PowerObserver,
26 NON_EXPORTED_BASE(public base::NonThreadSafe) { 26 NON_EXPORTED_BASE(public base::NonThreadSafe) {
27 public: 27 public:
28 // Construct a HttpNetworkLayer with an existing HttpNetworkSession which 28 // Construct a HttpNetworkLayer with an existing HttpNetworkSession which
29 // contains a valid ProxyService. 29 // contains a valid ProxyService. The HttpNetworkLayer must be destroyed
30 // before |session|.
30 explicit HttpNetworkLayer(HttpNetworkSession* session); 31 explicit HttpNetworkLayer(HttpNetworkSession* session);
31 ~HttpNetworkLayer() override; 32 ~HttpNetworkLayer() override;
32 33
33 // HttpTransactionFactory methods: 34 // HttpTransactionFactory methods:
34 int CreateTransaction(RequestPriority priority, 35 int CreateTransaction(RequestPriority priority,
35 scoped_ptr<HttpTransaction>* trans) override; 36 scoped_ptr<HttpTransaction>* trans) override;
36 HttpCache* GetCache() override; 37 HttpCache* GetCache() override;
37 HttpNetworkSession* GetSession() override; 38 HttpNetworkSession* GetSession() override;
38 39
39 // base::PowerObserver methods: 40 // base::PowerObserver methods:
40 void OnSuspend() override; 41 void OnSuspend() override;
41 void OnResume() override; 42 void OnResume() override;
42 43
43 private: 44 private:
44 const scoped_refptr<HttpNetworkSession> session_; 45 HttpNetworkSession* const session_;
45 bool suspended_; 46 bool suspended_;
46 47
47 DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer); 48 DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer);
48 }; 49 };
49 50
50 } // namespace net 51 } // namespace net
51 52
52 #endif // NET_HTTP_HTTP_NETWORK_LAYER_H_ 53 #endif // NET_HTTP_HTTP_NETWORK_LAYER_H_
OLDNEW
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698