Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: net/spdy/spdy_proxy_client_socket_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_proxy_client_socket_unittest.cc
diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc
index 9d3e03e412745b94bf8e368aad87a0c8a20c76bc..a8362e3c1b755673ccb83ddffd237492e713eb4c 100644
--- a/net/spdy/spdy_proxy_client_socket_unittest.cc
+++ b/net/spdy/spdy_proxy_client_socket_unittest.cc
@@ -123,7 +123,7 @@ class SpdyProxyClientSocketTest
BoundTestNetLog net_log_;
private:
- scoped_refptr<HttpNetworkSession> session_;
+ scoped_ptr<HttpNetworkSession> session_;
scoped_refptr<IOBuffer> read_buf_;
SpdySessionDependencies session_deps_;
MockConnect connect_data_;
@@ -147,7 +147,6 @@ INSTANTIATE_TEST_CASE_P(NextProto,
SpdyProxyClientSocketTest::SpdyProxyClientSocketTest()
: spdy_util_(GetParam()),
- session_(NULL),
read_buf_(NULL),
session_deps_(GetParam()),
connect_data_(SYNCHRONOUS, OK),
@@ -189,9 +188,8 @@ void SpdyProxyClientSocketTest::Initialize(MockRead* reads,
&session_deps_);
// Creates the SPDY session and stream.
- spdy_session_ =
- CreateInsecureSpdySession(
- session_, endpoint_spdy_session_key_, BoundNetLog());
+ spdy_session_ = CreateInsecureSpdySession(
+ session_.get(), endpoint_spdy_session_key_, BoundNetLog());
base::WeakPtr<SpdyStream> spdy_stream(
CreateStreamSynchronously(
SPDY_BIDIRECTIONAL_STREAM, spdy_session_, url_, LOWEST,

Powered by Google App Engine
This is Rietveld 408576698