net/http/http_network_session_peer.h - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session_peer.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_session_peer.h

diff --git a/net/http/http_network_session_peer.h b/net/http/http_network_session_peer.h

index 755e539cebb5f17c6e2c130cb035922c1248020e..346703d0e2ed5d5f2e9359ed1772aced6b50e734 100644

--- a/net/http/http_network_session_peer.h

+++ b/net/http/http_network_session_peer.h

@@ -18,8 +18,7 @@ class ProxyService;

class NET_EXPORT_PRIVATE HttpNetworkSessionPeer {

public:

- explicit HttpNetworkSessionPeer(

- const scoped_refptr<HttpNetworkSession>& session);

+ explicit HttpNetworkSessionPeer(HttpNetworkSession* session);

pauljensen 2015/09/11 13:05:25 should we add a comment like "|session| must outli

mmenke 2015/09/11 14:46:50 Done

~HttpNetworkSessionPeer();

void SetClientSocketPoolManager(

@@ -32,7 +31,7 @@ class NET_EXPORT_PRIVATE HttpNetworkSessionPeer {

scoped_ptr<HttpStreamFactory> http_stream_factory_for_websocket);

private:

- const scoped_refptr<HttpNetworkSession> session_;

+ HttpNetworkSession* const session_;

DISALLOW_COPY_AND_ASSIGN(HttpNetworkSessionPeer);

};