net/http/http_response_body_drainer_unittest.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_body_drainer_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_body_drainer_unittest.cc

diff --git a/net/http/http_response_body_drainer_unittest.cc b/net/http/http_response_body_drainer_unittest.cc

index ca206b7f5c7c71f2bdb9fb7d27d2de63608dfa40..0634d74220f29128130fc65f1fbd89b66e4c0b23 100644

--- a/net/http/http_response_body_drainer_unittest.cc

+++ b/net/http/http_response_body_drainer_unittest.cc

@@ -231,7 +231,7 @@ class HttpResponseBodyDrainerTest : public testing::Test {

scoped_refptr<SSLConfigService> ssl_config_service_;

scoped_ptr<HttpServerPropertiesImpl> http_server_properties_;

scoped_ptr<TransportSecurityState> transport_security_state_;

- const scoped_refptr<HttpNetworkSession> session_;

+ const scoped_ptr<HttpNetworkSession> session_;

CloseResultWaiter result_waiter_;

MockHttpStream* const mock_stream_; // Owned by |drainer_|.

HttpResponseBodyDrainer* const drainer_; // Deletes itself.