net/http/http_network_transaction_ssl_unittest.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_ssl_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_transaction_ssl_unittest.cc

diff --git a/net/http/http_network_transaction_ssl_unittest.cc b/net/http/http_network_transaction_ssl_unittest.cc

index 2db5a9997c92a73e2b74a7a0c561b9dec8d237db..06fc21a24113098d213dd70bdd08d95f38ee324c 100644

--- a/net/http/http_network_transaction_ssl_unittest.cc

+++ b/net/http/http_network_transaction_ssl_unittest.cc

@@ -127,7 +127,7 @@ TEST_F(HttpNetworkTransactionSSLTest, SSLFallback) {

StaticSocketDataProvider data3(NULL, 0, NULL, 0);

mock_socket_factory_.AddSocketDataProvider(&data3);

- scoped_refptr<HttpNetworkSession> session(

+ scoped_ptr<HttpNetworkSession> session(

new HttpNetworkSession(session_params_));

scoped_ptr<HttpNetworkTransaction> trans(

new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));