net/cert_net/cert_net_fetcher_impl_unittest.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert_net/cert_net_fetcher_impl_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert_net/cert_net_fetcher_impl_unittest.cc

diff --git a/net/cert_net/cert_net_fetcher_impl_unittest.cc b/net/cert_net/cert_net_fetcher_impl_unittest.cc

index e60241840496bf3630473a683c2324dac3b4930a..2cbc972c65b61b9a3a55c9fd2a25a66778391faf 100644

--- a/net/cert_net/cert_net_fetcher_impl_unittest.cc

+++ b/net/cert_net/cert_net_fetcher_impl_unittest.cc

@@ -48,10 +48,11 @@ class RequestContext : public URLRequestContext {

params.proxy_service = proxy_service();

params.ssl_config_service = ssl_config_service();

params.http_server_properties = http_server_properties();

- scoped_refptr<HttpNetworkSession> network_session(

- new HttpNetworkSession(params));

+ storage_.set_http_network_session(

+ make_scoped_ptr(new HttpNetworkSession(params)));

storage_.set_http_transaction_factory(new HttpCache(

- network_session.get(), HttpCache::DefaultBackend::InMemory(0)));

+ storage_.http_network_session(), HttpCache::DefaultBackend::InMemory(0),

+ false /* set_up_quic_server_info */));

URLRequestJobFactoryImpl* job_factory = new URLRequestJobFactoryImpl();

storage_.set_job_factory(job_factory);

}