Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: ios/crnet/crnet_environment.mm

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/crnet/crnet_environment.mm
diff --git a/ios/crnet/crnet_environment.mm b/ios/crnet/crnet_environment.mm
index 3eb873a1f081d1778b2e7c67710d9d22230e8ef6..479531b08fb8e69372ed4c5a6f4887eb95417c60 100644
--- a/ios/crnet/crnet_environment.mm
+++ b/ios/crnet/crnet_environment.mm
@@ -446,7 +446,12 @@ void CrNetEnvironment::InitializeOnNetworkThread() {
base::WorkerPool::GetTaskRunner(true));
}
- net::HttpCache* main_cache = new net::HttpCache(params, main_backend);
+ // TODO(mmenke): These really shouldn't be leaked.
+ // See http://crbug.com/523858.
pauljensen 2015/09/11 13:05:25 nit: http->https or personally I'd shorten it to j
mmenke 2015/09/11 14:46:49 Done (Went with https - some editors have build-in
+ net::HttpNetworkSession* http_network_session =
+ new net::HttpNetworkSession(params);
+ net::HttpCache* main_cache = new net::HttpCache(
+ http_network_session, main_backend, true /* set_up_quic_server_info */);
main_context_->set_http_transaction_factory(main_cache);
// Cookies

Powered by Google App Engine
This is Rietveld 408576698