Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: google_apis/gcm/tools/mcs_probe.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/profiles/profile_io_data.cc ('K') | « google_apis/gcm/engine/connection_factory_impl.cc ('k') | ios/crnet/crnet_environment.mm » ('j') | ios/crnet/crnet_environment.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/tools/mcs_probe.cc
diff --git a/google_apis/gcm/tools/mcs_probe.cc b/google_apis/gcm/tools/mcs_probe.cc
index 9d0881b0f139d798caefb07f8cbb419a975cd04f..1ee66d9d9e80a052de3aa0e512e34618d01aaf4b 100644
--- a/google_apis/gcm/tools/mcs_probe.cc
+++ b/google_apis/gcm/tools/mcs_probe.cc
@@ -229,7 +229,7 @@ class MCSProbe {
scoped_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory_;
scoped_ptr<net::HttpServerPropertiesImpl> http_server_properties_;
scoped_ptr<net::HostMappingRules> host_mapping_rules_;
- scoped_refptr<net::HttpNetworkSession> network_session_;
+ scoped_ptr<net::HttpNetworkSession> network_session_;
scoped_ptr<net::ProxyService> proxy_service_;
FakeGCMStatsRecorder recorder_;
@@ -293,7 +293,7 @@ void MCSProbe::Start() {
connection_factory_.reset(
new ConnectionFactoryImpl(endpoints,
kDefaultBackoffPolicy,
- network_session_,
+ network_session_.get(),
NULL,
&net_log_,
&recorder_));
@@ -403,7 +403,7 @@ void MCSProbe::BuildNetworkSession() {
session_params.net_log = &net_log_;
session_params.proxy_service = proxy_service_.get();
- network_session_ = new net::HttpNetworkSession(session_params);
+ network_session_.reset(new net::HttpNetworkSession(session_params));
}
void MCSProbe::ErrorCallback() {
« chrome/browser/profiles/profile_io_data.cc ('K') | « google_apis/gcm/engine/connection_factory_impl.cc ('k') | ios/crnet/crnet_environment.mm » ('j') | ios/crnet/crnet_environment.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698