Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: net/http/http_network_session.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed too much, back up a bit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index 50c319d37c4e3c3948afa56ecd12ab02428b7e44..bad31bc21e038923475e01c07529d044447eb8e3 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -56,8 +56,7 @@ class TransportSecurityState;
// This class holds session objects used by HttpNetworkTransaction objects.
class NET_EXPORT HttpNetworkSession
- : public base::RefCounted<HttpNetworkSession>,
- NON_EXPORTED_BASE(public base::NonThreadSafe) {
+ : NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
struct NET_EXPORT Params {
Params();
@@ -138,6 +137,7 @@ class NET_EXPORT HttpNetworkSession
};
explicit HttpNetworkSession(const Params& params);
+ ~HttpNetworkSession();
HttpAuthCache* http_auth_cache() { return &http_auth_cache_; }
SSLClientAuthCache* ssl_client_auth_cache() {
@@ -210,11 +210,8 @@ class NET_EXPORT HttpNetworkSession
bool HasSpdyExclusion(HostPortPair host_port_pair) const;
private:
- friend class base::RefCounted<HttpNetworkSession>;
friend class HttpNetworkSessionPeer;
- ~HttpNetworkSession();
-
ClientSocketPoolManager* GetSocketPoolManager(SocketPoolType pool_type);
NetLog* const net_log_;

Powered by Google App Engine
This is Rietveld 408576698