Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1606)

Issue 1298233004: Move a member function parentEditingBoundary() out from PositionAlgorithm<Strategy> template class (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move a member function parentEditingBoundary() out from PositionAlgorithm<Strategy> template class This patch moves a member function |parentEditingBoundary()| in |PositionAlgorithm<Strategy>| template class for a preparation of making it as static function in "VisibileUnits.cpp" since it is used only in "VisibileUnits.cpp". BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200827

Patch Set 1 : 2015-08-19T13:59:54 #

Patch Set 2 : 2015-08-19T22:31:05 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M Source/core/editing/Position.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 1 chunk +17 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 05:43:35 UTC) #1
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 06:32:18 UTC) #3
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-19 08:10:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298233004/1
5 years, 4 months ago (2015-08-19 08:33:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/86642) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-19 08:34:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298233004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298233004/60001
5 years, 4 months ago (2015-08-19 13:32:11 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 14:37:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200827

Powered by Google App Engine
This is Rietveld 408576698