Do not exclude localhost automatically

Do not exclude localhost automatically

BUG=471400
Android allows excluding localhost via wi-fi proxy setting and device policy manager. Do not exclude the localhost by default.

Committed: https://crrev.com/dc07f45653c5ff2a3478bc396ac5e35a99d103c6
Cr-Commit-Position: refs/heads/master@{#353872}

[sgurun-gerrit only, 2015-08-19 23:14:58]

sgurun@chromium.org changed reviewers:
+ eroman@chromium.org

[sgurun-gerrit only, 2015-08-19 23:15:11]

On 2015/08/19 23:14:58, sgurun wrote:
> mailto:sgurun@chromium.org changed reviewers:
> + mailto:eroman@chromium.org

PTAL, thanks

[eroman, 2015-08-19 23:35:53]

Is there a way to read those configs and set them in the chrome settings?

[sgurun-gerrit only, 2015-08-22 01:49:35]

On 2015/08/19 23:35:53, eroman wrote:
> Is there a way to read those configs and set them in the chrome settings?

sorry I could not get to this due to some fires. I guess you mean the existing
configurations that rely on localhost being excluded. I don't think so, if there
are some apps that simply rely on localhost being excluded automatically, these
will break or someone will have to manually configure the proxy configuration to
exclude localhost. 
This is why I am not super enthusiastic about it.

[eroman, 2015-08-24 22:02:53]

What I mean is, the bug report says that the Android system proxy settings now
include an option to "proxy exclusion settings for 'localhost'".

So where does proxy_config_service_android pick that new setting up. Is it
already being communicated and parsed correctly from the bypass list, or does
extra code need to be added to the class to check for it and update the returned
settings accordingly.

[sgurun-gerrit only, 2015-10-09 23:25:09]

On 2015/08/24 22:02:53, eroman wrote:
> What I mean is, the bug report says that the Android system proxy settings now
> include an option to "proxy exclusion settings for 'localhost'".
> 
> So where does proxy_config_service_android pick that new setting up. Is it
> already being communicated and parsed correctly from the bypass list, or does
> extra code need to be added to the class to check for it and update the
returned
> settings accordingly.

Hello, back to work on this.

Yes, you have a good point. AFAIK we handle and parse exclusion list correctly:
https://code.google.com/p/chromium/codesearch#chromium/src/net/android/java/s...

did some experiments with it passing single and multiple host names and wildcard
configs, and seems to work ok.

[eroman, 2015-10-10 00:19:25]

Thanks Selim.

Just to make sure I fully understand here:

The "bypass" list being passed to Chrome comes from:

http://developer.android.com/reference/android/net/ProxyInfo.html#getExclusio...

The documentation for that function doesn't say anything about how localhost
bypass is encoded (assuming that is an option).

For context, on Windows there is an option to bypass "localhost" which is
encoded as the magic <localhost> when retrieving the bypass list rules.

This is applied in a particular way by Chrome, to mean anything that is
127.0.0.1, [::1], or anything that contains a period in it:

https://code.google.com/p/chromium/codesearch#chromium/src/net/proxy/proxy_by...

Is there anything equivalent on the android config side, or would a user simply
enter distinct rules to bypass
  localhost
  127.0.0.1
  [::1]

when they want to do this?

Thanks!

[eroman, 2015-10-10 00:27:08]

Also, LGTM once previous comment is answered

[sgurun-gerrit only, 2015-10-13 01:12:42]

On 2015/10/10 00:27:08, eroman wrote:
> Also, LGTM once previous comment is answered


In Android there are two UI's that I know that one can use to enter proxy
information. I used the WiFi configuration one since it is more commonly known.

As you said, the documentation does not say anything. I did some experimentation
with HttpUrlConnection, and I see that one needs to enter distinct rules for
localhost and 127.0.0.1. The UI pattern does not allow entering the magic
<local> or [::1]. So essentially there is no way to exclude [::1] which is
annoying (and also a bug).

On the other hand, that is probably only a deficiency of UI since all the
framework does is to set the java VMs property for exclusion after substituting
"," with "|".

android/net/Proxy.java:
    if (exclList != null) exclList = exclList.replace(",", "|");
    ...
    if (exclList != null) {
            System.setProperty("http.nonProxyHosts", exclList);
            System.setProperty("https.nonProxyHosts", exclList);
        } else {
            System.clearProperty("http.nonProxyHosts");
            System.clearProperty("https.nonProxyHosts");
        }
The java spec for proxies don't mention a magic <local>. 
https://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html


it does not talk about IPv6 either, but at this moment I assume [::1] is a valid
string.

[sgurun-gerrit only, 2015-10-13 20:57:43]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2015-10-13 21:05:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298223007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298223007/1

[commit-bot: I haz the power, 2015-10-13 22:18:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-13 22:19:18]

Patchset 1 (id:??) landed as
https://crrev.com/dc07f45653c5ff2a3478bc396ac5e35a99d103c6
Cr-Commit-Position: refs/heads/master@{#353872}