Issue 12982008: Fixed some soft-float bugs for MIPS and ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12982008: Fixed some soft-float bugs for MIPS and ARM. (Closed)

Created:
7 years, 9 months ago by dusmil

Modified:
7 years, 8 months ago

Reviewers:
Paul Lind, danno, kisg, Hannes Payer (out of office), palfia, kilvadyb, hans

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed some soft-float bugs for MIPS and ARM. TEST=cctest/test-api/ExternalUnsignedIntArray BUG=

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/mips/lithium-codegen-mips.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Paul Lind

LGTM, but since this includes ARM fix, we also need v8-team review. This is for ...

7 years, 9 months ago (2013-03-27 15:52:13 UTC) #2

hans

ARM side looks good to me. I'm not a proper reviewer though, so someone from ...

7 years, 9 months ago (2013-03-28 14:29:41 UTC) #3

Paul Lind

I see that Rodolph Perfetta has a (currently un-landed) CL https://codereview.chromium.org/13008018/ to address the ARM ...

7 years, 8 months ago (2013-03-30 18:13:24 UTC) #4

dusmil

7 years, 8 months ago (2013-04-01 09:42:57 UTC) #5

I agree. I will close this issue and open new one with patch for MIPS.