Address some additional cleanup work needed for the component flash updates on Linux.

Address some additional cleanup work needed for the component flash updates on Linux.

BUG=460595
Committed: https://crrev.com/6e33976aaa05c8da8f7950ee71e3e445f3668b36
Cr-Commit-Position: refs/heads/master@{#344010}

[Greg K, 2015-08-17 21:06:55]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-08-17 21:18:30]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-08-17 21:18:31]

https://codereview.chromium.org/1298013002/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1298013002/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:82:
base::FilePath base_dir = GetPepperFlashBaseDirectory();
(re: compiler failure) Oh, I didn't see this.

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
File chrome/common/component_flash_hint_file_linux.h (right):

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
chrome/common/component_flash_hint_file_linux.h:11: #error "This file only
applies to the Linux component update of flash."
flash -> Flash

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
chrome/common/component_flash_hint_file_linux.h:20: namespace chrome {
Can we remove the chrome namespace?

[Greg K, 2015-08-17 22:57:45]

https://codereview.chromium.org/1298013002/diff/20001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1298013002/diff/20001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:82:
base::FilePath base_dir = GetPepperFlashBaseDirectory();
On 2015/08/17 21:18:30, Lei Zhang wrote:
> (re: compiler failure) Oh, I didn't see this.

I fixed this by putting it into the GOOGLE_CHROME_BUILD #ifdefs.

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
File chrome/common/component_flash_hint_file_linux.h (right):

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
chrome/common/component_flash_hint_file_linux.h:11: #error "This file only
applies to the Linux component update of flash."
On 2015/08/17 21:18:31, Lei Zhang wrote:
> flash -> Flash

Done.

https://codereview.chromium.org/1298013002/diff/20001/chrome/common/component...
chrome/common/component_flash_hint_file_linux.h:20: namespace chrome {
On 2015/08/17 21:18:31, Lei Zhang wrote:
> Can we remove the chrome namespace?

Done.

[Lei Zhang, 2015-08-17 23:34:58]

Just one issue.

https://codereview.chromium.org/1298013002/diff/40001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1298013002/diff/40001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:79:
base::FilePath base_dir = GetPepperFlashBaseDirectory();
Don't we want to get the correct |base_dir| here? i.e.
GetPepperFlashBaseDirectory() doesn't check the PathService::Get() result, but
should. Once you do that in GetPepperFlashBaseDirectory(), it becomes a bit of a
useless wrapper...

[Greg K, 2015-08-18 18:01:16]

https://codereview.chromium.org/1298013002/diff/40001/chrome/browser/componen...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

https://codereview.chromium.org/1298013002/diff/40001/chrome/browser/componen...
chrome/browser/component_updater/pepper_flash_component_installer.cc:79:
base::FilePath base_dir = GetPepperFlashBaseDirectory();
On 2015/08/17 23:34:58, Lei Zhang wrote:
> Don't we want to get the correct |base_dir| here? i.e.
> GetPepperFlashBaseDirectory() doesn't check the PathService::Get() result, but
> should. Once you do that in GetPepperFlashBaseDirectory(), it becomes a bit of
a
> useless wrapper...

Done.

[Lei Zhang, 2015-08-18 19:16:26]

lgtm

[Greg K, 2015-08-18 20:09:42]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298013002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298013002/60001

[commit-bot: I haz the power, 2015-08-18 20:15:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-08-18 20:15:40]

Patchset 3 (id:??) landed as
https://crrev.com/6e33976aaa05c8da8f7950ee71e3e445f3668b36
Cr-Commit-Position: refs/heads/master@{#344010}