Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1298003004: Add v8_experimental_extra_library_files gn parameter (Closed)

Created:
5 years, 4 months ago by domenic
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add v8_experimental_extra_library_files gn parameter This is required for https://codereview.chromium.org/1284413002 R=brettw@chromium.org BUG=507137 Committed: https://crrev.com/106badddb9b745f73e56909864e12fbeef6f4003 Cr-Commit-Position: refs/heads/master@{#344278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/module_args/v8.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
domenic
5 years, 4 months ago (2015-08-17 20:57:20 UTC) #1
domenic
Jochen is on vacation. mmentovai@ suggested diranke@ for gn things.
5 years, 4 months ago (2015-08-17 22:43:11 UTC) #3
domenic
5 years, 4 months ago (2015-08-19 16:44:45 UTC) #5
brettw
lgtm
5 years, 4 months ago (2015-08-19 16:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298003004/1
5 years, 4 months ago (2015-08-19 17:03:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 18:26:08 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 18:26:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/106badddb9b745f73e56909864e12fbeef6f4003
Cr-Commit-Position: refs/heads/master@{#344278}

Powered by Google App Engine
This is Rietveld 408576698