Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1284413002: Add experimental, non-snapshotted V8 extras (Closed)

Created:
5 years, 4 months ago by domenic
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@non-experimental-extras
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add experimental, non-snapshotted V8 extras Embedders would use these for features which must be able to be turned off at runtime, despite being compiled into V8. They can be turned on and off by the embedder using the --experimental_extras flag, e.g. via v8::SetFlagsFromString. R=yangguo@chromium.org, mlippautz@chromium.org, hpayer@chromium.org BUG=chromium:507137 LOG=Y Committed: https://crrev.com/6f582f088aec1b727fce3c87b89e38d2c25ab468 Cr-Commit-Position: refs/heads/master@{#30260}

Patch Set 1 #

Patch Set 2 : Add test; rebase #

Patch Set 3 : rebase #

Patch Set 4 : Add missing inline #

Patch Set 5 : #

Patch Set 6 : Fix missing change #

Patch Set 7 : Rebase, maybe everything will work now #

Patch Set 8 : Fix base URL #

Patch Set 9 : Was still missing a gyp entry wtf #

Patch Set 10 : Rebase on latest macros #

Patch Set 11 : Missing gn entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -8 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 8 chunks +37 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 6 chunks +37 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M src/snapshot/natives.h View 1 2 3 4 5 6 7 8 9 2 chunks +10 lines, -1 line 0 comments Download
M src/snapshot/natives-common.cc View 1 2 3 4 5 6 7 8 9 2 chunks +8 lines, -0 lines 0 comments Download
M src/snapshot/natives-external.cc View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 chunks +30 lines, -3 lines 0 comments Download
A + test/cctest/test-experimental-extra.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 7 8 9 6 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 45 (18 generated)
domenic
Depends on previous CL https://codereview.chromium.org/1289603002
5 years, 4 months ago (2015-08-12 21:47:03 UTC) #1
Yang
LGTM, but it would be very nice if we had a test case for experimental ...
5 years, 4 months ago (2015-08-13 12:35:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/20001
5 years, 4 months ago (2015-08-13 18:33:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/6936) v8_linux_gcc_compile_rel on ...
5 years, 4 months ago (2015-08-13 18:33:49 UTC) #6
domenic
On 2015/08/13 at 12:35:31, yangguo wrote: > LGTM, but it would be very nice if ...
5 years, 4 months ago (2015-08-13 18:35:43 UTC) #7
Yang
On 2015/08/13 18:35:43, domenic wrote: > On 2015/08/13 at 12:35:31, yangguo wrote: > > LGTM, ...
5 years, 4 months ago (2015-08-14 07:53:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/40001
5 years, 4 months ago (2015-08-14 19:25:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3287) v8_linux_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-08-14 19:28:17 UTC) #13
domenic
On 2015/08/14 at 19:28:17, commit-bot wrote: > Try jobs failed on following builders: > v8_linux64_avx2_rel ...
5 years, 4 months ago (2015-08-14 19:33:57 UTC) #14
Yang
On 2015/08/14 19:33:57, domenic wrote: > On 2015/08/14 at 19:28:17, commit-bot wrote: > > Try ...
5 years, 4 months ago (2015-08-14 19:52:32 UTC) #15
Yang
Hannes or Michael, could one of you review the heap changes?
5 years, 4 months ago (2015-08-17 07:06:22 UTC) #17
Michael Lippautz
heap lgtm
5 years, 4 months ago (2015-08-17 08:32:42 UTC) #18
Hannes Payer (out of office)
lgtm after fixing build error. Moreover, set BUG= to BUG=chromium:507137
5 years, 4 months ago (2015-08-17 09:45:58 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/60001
5 years, 4 months ago (2015-08-17 15:58:23 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8694)
5 years, 4 months ago (2015-08-17 16:02:07 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/80001
5 years, 4 months ago (2015-08-17 18:14:47 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8730)
5 years, 4 months ago (2015-08-17 18:18:35 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/100001
5 years, 4 months ago (2015-08-17 18:25:03 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8735)
5 years, 4 months ago (2015-08-17 18:33:27 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/160001
5 years, 4 months ago (2015-08-17 19:47:54 UTC) #33
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/7050)
5 years, 4 months ago (2015-08-17 19:53:28 UTC) #35
domenic
Thanks all for the help. The external snapshot change this morning made fixing the build ...
5 years, 4 months ago (2015-08-17 20:58:36 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/180001
5 years, 4 months ago (2015-08-19 20:19:51 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/7149)
5 years, 4 months ago (2015-08-19 20:25:48 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284413002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284413002/200001
5 years, 4 months ago (2015-08-19 23:00:08 UTC) #43
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 4 months ago (2015-08-20 00:01:12 UTC) #44
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 00:01:21 UTC) #45
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/6f582f088aec1b727fce3c87b89e38d2c25ab468
Cr-Commit-Position: refs/heads/master@{#30260}

Powered by Google App Engine
This is Rietveld 408576698