Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1297993005: Cleanup the remaining references to source_view_id (Closed)

Created:
5 years, 4 months ago by sgurun-gerrit only
Modified:
5 years, 4 months ago
Reviewers:
alexmos, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup the remaining references to source_view_id BUG=473258 When Android webview implemented message ports, it set the source frame to target frame simply to be able transfer message ports, as blink required a valid source frame. Now the requirement is gone, cleanup the logic. Committed: https://crrev.com/b7dd90bc849f4f3eebfdf0a5ad72b275104a4483 Cr-Commit-Position: refs/heads/master@{#344302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/message_port_provider.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sgurun-gerrit only
On 2015/08/19 01:12:19, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:nasko@chromium.org nasko@ ptal, this ...
5 years, 4 months ago (2015-08-19 01:12:37 UTC) #2
nasko
Adding alexmos@, as he has done most of the work on postMessage to double check ...
5 years, 4 months ago (2015-08-19 16:44:45 UTC) #4
alexmos
LGTM, thanks for the cleanup! I've started the linux_site_isolation trybot to also double-check the postMessage ...
5 years, 4 months ago (2015-08-19 16:56:06 UTC) #5
sgurun-gerrit only
On 2015/08/19 16:56:06, alexmos wrote: > LGTM, thanks for the cleanup! I've started the linux_site_isolation ...
5 years, 4 months ago (2015-08-19 17:43:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297993005/1
5 years, 4 months ago (2015-08-19 17:44:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 19:23:52 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 19:24:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7dd90bc849f4f3eebfdf0a5ad72b275104a4483
Cr-Commit-Position: refs/heads/master@{#344302}

Powered by Google App Engine
This is Rietveld 408576698