Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/browser/message_port_provider.cc

Issue 1297993005: Cleanup the remaining references to source_view_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/message_port_provider.cc
diff --git a/content/browser/message_port_provider.cc b/content/browser/message_port_provider.cc
index ddd19adb87472d978b63b0a8328bcec1957984c6..989925b7855727b2f4c7dcbe41075f786f56c3b0 100644
--- a/content/browser/message_port_provider.cc
+++ b/content/browser/message_port_provider.cc
@@ -28,13 +28,6 @@ void MessagePortProvider::PostMessageToFrame(
FrameMsg_PostMessage_Params params;
params.is_data_raw_string = true;
params.data = data;
- // Blink requires a source frame to transfer ports. This is why a
- // source routing id is set here. See WebDOMMessageEvent::initMessageEvent()
- // TODO(alexmos, sgurun): Clean this up once crbug.com/473258 is fixed.
- // Once message ports can work with a null source frame,
- // source_view_routing_id can be removed, and this can just pass in
- // MSG_ROUTING_NONE for the source frame.
- params.source_view_routing_id = web_contents->GetRoutingID();
params.source_routing_id = MSG_ROUTING_NONE;
params.source_origin = source_origin;
params.target_origin = target_origin;
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698