QUIC - reorganize common code between quic_client and quic_simple_client

QUIC - reorganize common code between quic_client and quic_simple_client
into quic_client_base.* files.

R=rch@chromium.org

Committed: https://crrev.com/d67b3a7256e5a1e30ac6044f91fa8c86c984c37f
Cr-Commit-Position: refs/heads/master@{#343810}

[ramant (doing other things), 2015-08-15 02:04:24]

Patchset #1 (id:1) has been deleted

[ramant (doing other things), 2015-08-15 03:51:47]

Patchset #1 (id:20001) has been deleted

[ramant (doing other things), 2015-08-17 18:03:44]

rtenneti@chromium.org changed reviewers:
+ rch@chromium.org

[ramant (doing other things), 2015-08-17 18:09:41]

Hi Ryan,
  This is a first cut sharing the code between quic_client and
quic_simple_client. Didn't share the code that is not common: code that touches
BalsaHeaders/HttpResponseHeaders and socket related methods.

PTAL.

thanks
raman

[Ryan Hamilton, 2015-08-17 19:21:20]

LGTM though it would be great to get better diffs for quic_client_base.{h,cc}

https://codereview.chromium.org/1297853002/diff/60001/net/tools/quic/quic_cli...
File net/tools/quic/quic_client_base.h (right):

https://codereview.chromium.org/1297853002/diff/60001/net/tools/quic/quic_cli...
net/tools/quic/quic_client_base.h:1: // Copyright (c) 2015 The Chromium Authors.
All rights reserved.
I wonder if you can convince git that this is really a copy of quic_client.h
(and same for the .cc). Perhaps you could land a CL which merely copies
quic_client.h to quic_client_base.h then rebase this CL on top of that? Or
perhaps just upload that as patch set 1?

[ramant (doing other things), 2015-08-17 19:55:07]

Patchset #3 (id:80001) has been deleted

[ramant (doing other things), 2015-08-17 20:00:39]

Uploaded quic_client_base.* changes one more time. PTAL.

Thanks Ryan.

[ramant (doing other things), 2015-08-17 20:02:56]

https://codereview.chromium.org/1297853002/diff/60001/net/tools/quic/quic_cli...
File net/tools/quic/quic_client_base.h (right):

https://codereview.chromium.org/1297853002/diff/60001/net/tools/quic/quic_cli...
net/tools/quic/quic_client_base.h:1: // Copyright (c) 2015 The Chromium Authors.
All rights reserved.
On 2015/08/17 19:21:20, Ryan Hamilton wrote:
> I wonder if you can convince git that this is really a copy of quic_client.h
> (and same for the .cc). Perhaps you could land a CL which merely copies
> quic_client.h to quic_client_base.h then rebase this CL on top of that? Or
> perhaps just upload that as patch set 1?

Done.

[Ryan Hamilton, 2015-08-17 23:21:44]

lgtm

[ramant (doing other things), 2015-08-17 23:37:38]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-08-17 23:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297853002/120001

[commit-bot: I haz the power, 2015-08-18 02:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 02:12:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2015-08-18 02:14:25]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-08-18 02:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297853002/120001

[commit-bot: I haz the power, 2015-08-18 05:15:38]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-08-18 05:16:24]

Patchset 4 (id:??) landed as
https://crrev.com/d67b3a7256e5a1e30ac6044f91fa8c86c984c37f
Cr-Commit-Position: refs/heads/master@{#343810}