fpdfsdk/src/fsdk_actionhandler.cpp - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_actionhandler.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fsdk_actionhandler.cpp

diff --git a/fpdfsdk/src/fsdk_actionhandler.cpp b/fpdfsdk/src/fsdk_actionhandler.cpp

index 5a2063e6dc480f621c0a1fc39c0a33493f4b8987..a16c21a321e538c151afff89e49c3599f219c2d5 100644

--- a/fpdfsdk/src/fsdk_actionhandler.cpp

+++ b/fpdfsdk/src/fsdk_actionhandler.cpp

@@ -534,8 +534,7 @@ void CPDFSDK_ActionHandler::DoAction_GoTo(CPDFSDK_Document* pDocument,

sizeOfAry = j;

}

pApp->FFI_DoGoToAction(nPageIndex, nFitType, pPosAry, sizeOfAry);

- if (pPosAry)

- delete[] pPosAry;

+ delete[] pPosAry;

}

void CPDFSDK_ActionHandler::DoAction_GoToR(CPDFSDK_Document* pDocument,