fpdfsdk/src/fsdk_baseform.cpp - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_baseform.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fsdk_baseform.cpp

diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp

index ca0c29efa49d1abfd0acbabe9f3647e1317e4e5c..eab9f91076f12c5eb19df39e2cf3aae5ff57f54f 100644

--- a/fpdfsdk/src/fsdk_baseform.cpp

+++ b/fpdfsdk/src/fsdk_baseform.cpp

@@ -2190,7 +2190,7 @@ FX_BOOL CPDFSDK_InterForm::SubmitForm(const CFX_WideString& sDestination,

pEnv->JS_docSubmitForm(pBuffer, nBufSize, sDestination.c_str());

- if (bUrlEncoded && pBuffer) {

+ if (bUrlEncoded) {

FX_Free(pBuffer);

pBuffer = NULL;

}