Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2474)

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
index 3c8b2567fe8490005271a4154acd07fd690b7e8f..ffba4b40a4b411aad871a895a5adbee18a6a3e76 100644
--- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
+++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp
@@ -301,15 +301,9 @@ CPDF_CMap::CPDF_CMap() {
m_nCodeRanges = 0;
}
CPDF_CMap::~CPDF_CMap() {
- if (m_pMapping) {
FX_Free(m_pMapping);
Tom Sepez 2015/08/14 21:21:34 nit: indentations.
Lei Zhang 2015/08/14 21:43:14 I was being sloppy and hoping for clang-format to
- }
- if (m_pAddMapping) {
FX_Free(m_pAddMapping);
- }
- if (m_pLeadingBytes) {
FX_Free(m_pLeadingBytes);
- }
delete m_pUseMap;
}
void CPDF_CMap::Release() {

Powered by Google App Engine
This is Rietveld 408576698