Don't bother checking pointers before delete[] and FX_Free().

core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_resource.h"
 #include "../../../include/fxge/fx_freetype.h"
@@ skipping 283 matching lines @@
   m_bVertical = 0;
   m_bLoaded = FALSE;
   m_pMapping = NULL;
   m_pLeadingBytes = NULL;
   m_pAddMapping = NULL;
   m_pEmbedMap = NULL;
   m_pUseMap = NULL;
   m_nCodeRanges = 0;
 }
 CPDF_CMap::~CPDF_CMap() {
-  if (m_pMapping) {
     FX_Free(m_pMapping);

[Tom Sepez, 2015/08/14 21:21:34]

nit: indentations.

[Lei Zhang, 2015/08/14 21:43:14]

I was being sloppy and hoping for clang-format to fix it all. Apparently not.

-  }
-  if (m_pAddMapping) {
     FX_Free(m_pAddMapping);
-  }
-  if (m_pLeadingBytes) {
     FX_Free(m_pLeadingBytes);
-  }
   delete m_pUseMap;
 }
 void CPDF_CMap::Release() {
   if (m_PredefinedCMap.IsEmpty()) {
     delete this;
   }
 }
 const CPDF_PredefinedCMap g_PredefinedCMaps[] = {
     {"GB-EUC",
      CIDSET_GB1,
@@ skipping 1333 matching lines @@
     if (middlecode > CID) {
       end = middle - 1;
     } else if (middlecode < CID) {
       begin = middle + 1;
     } else {
       return &Japan1_VertCIDs[middle].a;
     }
   }
   return NULL;
 }