Issue 12976005: Get rid of the single test_case code path.

Issue 12976005: Get rid of the single test_case code path. (Closed)

Created:
7 years, 9 months ago by M-A Ruel

Modified:
7 years, 9 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/swarm_client

Visibility:
Public.

More Reviews

Description

Get rid of the single test_case code path. This makes the code easier to convert to incremental processing. On the other hand, it removes any output prologue which could be interesting. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189812

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase take two #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -97 lines)			Patch
M	run_test_cases.py	View	1	1 chunk	+2 lines, -17 lines	0 comments	Download
M	tests/gtest_fake/expected.xml	View		1 chunk	+3 lines, -51 lines	0 comments	Download
M	tests/gtest_fake/gtest_fake_base.py	View		1 chunk	+14 lines, -5 lines	0 comments	Download
M	tests/run_test_cases_smoke_test.py	View		3 chunks	+5 lines, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12976005/4001

7 years, 9 months ago (2013-03-22 13:40:40 UTC) #3

commit-bot: I haz the power

Presubmit check for 12976005-4001 failed and returned exit status 1. INFO:root:Found 4 file(s). INFO:PRESUBMIT:Running pylint ...

7 years, 9 months ago (2013-03-22 13:41:24 UTC) #4

Presubmit check for 12976005-4001 failed and returned exit status 1.

INFO:root:Found 4 file(s).
INFO:PRESUBMIT:Running pylint on 64 files
test_large (__main__.IsolateServerTest) ... ok
test_missing (__main__.IsolateServerTest) ... ok
test_present (__main__.IsolateServerTest) ... ok
test_process_items (__main__.IsolateServerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.104s

OK
test_load_isolated_bad (__main__.RunIsolatedTest) ... ok
test_load_isolated_empty (__main__.RunIsolatedTest) ... ok
test_load_isolated_good (__main__.RunIsolatedTest) ... ok
test_load_isolated_os_bad (__main__.RunIsolatedTest) ... ok
test_load_isolated_os_only (__main__.RunIsolatedTest) ... ok
test_remote_no_errors (__main__.RunIsolatedTest) ... ok
test_remote_with_errors (__main__.RunIsolatedTest) ... ok
test_zip_header_error (__main__.RunIsolatedTest) ... ok
testCountKeyInData (__main__.UrlHelperTest) ... ok
testUrlOpenFailure (__main__.UrlHelperTest) ... ok
testUrlOpenGETSuccess (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorNoRetry (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorRetry404 (__main__.UrlHelperTest) ... ok
testUrlOpenHTTPErrorWithRetry (__main__.UrlHelperTest) ... ok
testUrlOpenPOSTSuccess (__main__.UrlHelperTest) ... ok
testUrlOpenSuccessAfterFailure (__main__.UrlHelperTest) ... ok

----------------------------------------------------------------------
Ran 16 tests in 0.025s

OK
A basic linux manifest test to ensure that windows specific values ... ok
test_basic_manifest (__main__.ManifestTest) ... ok
test_process_manifest_success (__main__.ManifestTest) ... ok
test_process_manifest_success_zip_already_uploaded (__main__.ManifestTest) ...
ok

----------------------------------------------------------------------
Ran 4 tests in 0.007s

OK
Zipping up files...
Zipping completed, time elapsed: 0.000017
Zip file not on server, starting uploading.
Sending test requests to swarm
Zipping up files...
Zipping completed, time elapsed: 0.000014
Zip file already on server, no need to reupload.
Sending test requests to swarm
test_simple (__main__.TraceTestCases) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.602s

OK
test_archive_empty_file (__main__.IsolateServerArchiveSmokeTest) ... ok
test_archive_small_file (__main__.IsolateServerArchiveSmokeTest) ... FAIL

======================================================================
FAIL: test_archive_small_file (__main__.IsolateServerArchiveSmokeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/isolateserver_archive_smoke_test.py",
line 86, in test_archive_small_file
    self._archive_given_files(['small_file.txt'])
  File
"/b/commit-queue/workdir/tools/swarm_client/tests/isolateserver_archive_smoke_test.py",
line 80, in _archive_given_files
    'File %s was missing from the server' % files[i])
AssertionError: File small_file.txt was missing from the server

----------------------------------------------------------------------
Ran 2 tests in 5.308s

FAILED (failures=1)
test_shards (__main__.ListTestCasesTest) ... ok
testRunSome (__main__.RunTestCases) ... ok
testStatsInfinite (__main__.RunTestCases) ... ok
test_calc_cluster_default (__main__.RunTestCases) ... ok
test_call_with_timeout (__main__.RunTestCases) ... printingprintingok
test_gtest_filter (__main__.RunTestCases) ... ok
test_process_output_crash_cr (__main__.RunTestCases) ... ok
test_process_output_crash_garbage_ok (__main__.RunTestCases) ... ok
test_process_output_crash_ok (__main__.RunTestCases) ... ok
test_process_output_crashes (__main__.RunTestCases) ... ok
test_process_output_fail_1 (__main__.RunTestCases) ... ok
test_process_output_garbage (__main__.RunTestCases) ... ok
test_process_output_missing (__main__.RunTestCases) ... ok
test_process_output_ok (__main__.RunTestCases) ... ok
test_recv_any (__main__.RunTestCases) ... printingprintingprintingprintingok
test_gen_xml (__main__.RunTestCasesTmp) ... ok
test_xml (__main__.RunTestCasesTmp) ... ok
test_xml_default (__main__.RunTestCasesTmp) ... ok
test_exception (__main__.WorkerPoolTest) ... ok
test_normal (__main__.WorkerPoolTest) ... ok

----------------------------------------------------------------------
Ran 20 tests in 2.385s

OK
test_100_variables (__main__.Tests) ... ok
test_multiple_nontrivial_regions (__main__.Tests) ... ok
test_partitions (__main__.Tests) ... ok
test_short_expression_finder_failure (__main__.Tests) ... ok
test_simple (__main__.Tests) ... ok
test_single_nontrivial_region (__main__.Tests) ... ok
test_two_variables_four_values (__main__.Tests) ... ok

----------------------------------------------------------------------
Ran 7 tests in 0.085s

OK
test_help_modes (__main__.Isolate) ... ok
test_modes (__main__.Isolate) ... ok
test_check (__main__.IsolateNoOutdir) ... ok
test_hashtable (__main__.IsolateNoOutdir) ... ok
test_remap (__main__.IsolateNoOutdir) ... ok
test_run (__main__.IsolateNoOutdir) ... ok
test_trace_read_merge (__main__.IsolateNoOutdir) ... ok
test_all_items_invalid (__main__.Isolate_check) ... ok
test_fail (__main__.Isolate_check) ... ok
test_missing_trailing_slash (__main__.Isolate_check) ... ok
test_no_run (__main__.Isolate_check) ... ok
test_non_existent (__main__.Isolate_check) ... ok
test_symlink_full (__main__.Isolate_check) ... ok
test_symlink_outside_build_root (__main__.Isolate_check) ... ok
test_symlink_partial (__main__.Isolate_check) ... ok
test_touch_root (__main__.Isolate_check) ... ok
test_with_flag (__main__.Isolate_check) ... ok
test_all_items_invalid (__main__.Isolate_hashtable) ... ok
test_fail (__main__.Isolate_hashtable) ... ok
test_missing_trailing_slash (__main__.Isolate_hashtable) ... ok
test_no_run (__main__.Isolate_hashtable) ... ok
test_non_existent (__main__.Isolate_hashtable) ... ok
test_split (__main__.Isolate_hashtable) ... ok
test_symlink_full (__main__.Isolate_hashtable) ... ok
test_symlink_outside_build_root (__main__.Isolate_hashtable) ... ok
test_symlink_partial (__main__.Isolate_hashtable) ... ok
test_touch_root (__main__.Isolate_hashtable) ... ok
test_with_flag (__main__.Isolate_hashtable) ... ok
test_all_items_invalid (__main__.Isolate_remap) ... ok
test_fail (__main__.Isolate_remap) ... ok
test_missing_trailing_slash (__main__.Isolate_remap) ... ok
test_no_run (__main__.Isolate_remap) ... ok
test_non_existent (__main__.Isolate_remap) ... ok
test_symlink_full (__main__.Isolate_remap) ... ok
test_symlink_outside_build_root (__main__.Isolate_remap) ... ok
test_symlink_partial (__main__.Isolate_remap) ... ok
test_touch_root (__main__.Isolate_remap) ... ok
test_with_flag (__main__.Isolate_remap) ... ok
test_all_items_invalid (__main__.Isolate_run) ... ok
test_fail (__main__.Isolate_run) ... ok
test_missing_trailing_slash (__main__.Isolate_run) ... ok
test_no_run (__main__.Isolate_run) ... ok
test_non_existent (__main__.Isolate_run) ... ok
test_symlink_full (__main__.Isolate_run) ... ok
test_symlink_outside_build_root (__main__.Isolate_run) ... ok
test_symlink_partial (__main__.Isolate_run) ... ok
test_touch_root (__main__.Isolate_run) ... ok
test_with_flag (__main__.Isolate_run) ... ok
test_all_items_invalid (__main__.Isolate_trace_read_merge) ... ok
test_fail (__main__.Isolate_trace_read_merge) ... ok
test_missing_trailing_slash (__main__.Isolate_trace_read_merge) ... ok
test_no_run (__main__.Isolate_trace_read_merge) ... ok
test_non_existent (__main__.Isolate_trace_read_merge) ... ok
test_symlink_full (__main__.Isolate_trace_read_merge) ... ok
test_symlink_outside_build_root (__main__.Isolate_trace_read_merge) ... ok
test_symlink_partial (__main__.Isolate_trace_read_merge) ... ok
test_touch_root (__main__.Isolate_trace_read_merge) ... ok
test_with_flag (__main__.Isolate_trace_read_merge) ... ok

----------------------------------------------------------------------
Ran 58 tests in 10.304s

OK
test_simple (__main__.IsolateTestCases) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.747s

OK
test_simple (__main__.FixTestCases) ... ok

----------------------------------------------------------------------
Ran 1 test in 1.925s

OK
test_chmod (__main__.StraceInputs) ... ok
test_clone (__main__.StraceInputs) ... ok
test_clone_chdir (__main__.StraceInputs) ... ok
test_close (__main__.StraceInputs) ... ok
test_empty (__main__.StraceInputs) ... ok
test_execve (__main__.StraceInputs) ... ok
test_faccess (__main__.StraceInputs) ... ok
test_futex_died (__main__.StraceInputs) ... ok
test_futex_missing_in_action (__main__.StraceInputs) ... ok
test_futex_missing_in_partial_action (__main__.StraceInputs) ... ok
test_futex_missing_in_partial_action_with_no_process (__main__.StraceInputs) ...
ok
test_open (__main__.StraceInputs) ... ok
test_open_resumed (__main__.StraceInputs) ... ok
test_openat (__main__.StraceInputs) ... ok
test_openat_died (__main__.StraceInputs) ... ok
test_rmdir (__main__.StraceInputs) ... ok
test_setxattr (__main__.StraceInputs) ... ok
test_sig_unexpected (__main__.StraceInputs) ... ok
test_stray (__main__.StraceInputs) ... ok
test_truncate (__main__.StraceInputs) ... ok
test_CsvReader (__main__.TraceInputs) ... ok
test_native_case_end_with_os_path_sep (__main__.TraceInputs) ... ok
test_native_case_non_existing (__main__.TraceInputs) ... ok
test_native_case_symlink_right_case (__main__.TraceInputs) ... ok
test_process_escaped_arguments (__main__.TraceInputs) ... ok
test_process_quoted_arguments (__main__.TraceInputs) ... ok
test_strace_filename (__main__.TraceInputs) ... ok
test_symlink (__main__.TraceInputs) ... ok
test_variable_abs (__main__.TraceInputs) ... ok
test_variable_rel (__main__.TraceInputs) ... ok

----------------------------------------------------------------------
Ran 30 tests in 0.026s

OK
test_flaky_stop_early (__main__.RunTestCases) ... ok
test_flaky_stop_early_xml (__main__…
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/12976005/4001

7 years, 9 months ago (2013-03-22 15:21:06 UTC) #5

Message was sent while issue was closed.

Change committed as 189812

Expand Messages | Collapse Messages