Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: tests/run_test_cases_smoke_test.py

Issue 12976005: Get rid of the single test_case code path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/swarm_client
Patch Set: Rebase take two Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/gtest_fake/gtest_fake_base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/run_test_cases_smoke_test.py
diff --git a/tests/run_test_cases_smoke_test.py b/tests/run_test_cases_smoke_test.py
index 6098124cf5bcc56a17ad8e66d6c60a6b93498e67..16af88a295177cba6259462409760ccfec4db1b3 100755
--- a/tests/run_test_cases_smoke_test.py
+++ b/tests/run_test_cases_smoke_test.py
@@ -245,15 +245,9 @@ class RunTestCases(unittest.TestCase):
for index, name in enumerate(test_cases):
expected_out_re.append(
r'\[%d/\d\] \d\.\d\ds ' % (index + 1) + re.escape(name) + ' .+')
- expected_out_re.append(re.escape('Note: Google Test filter = ' + name))
- expected_out_re.append('')
expected_out_re.extend(
re.escape(l) for l in
- gtest_fake_base.get_test_output(name, False).splitlines())
- expected_out_re.append('')
- expected_out_re.extend(
- re.escape(l) for l in gtest_fake_base.get_footer(1, 1).splitlines())
- expected_out_re.append('')
+ gtest_fake_base.get_test_output_inner(name, False).splitlines())
expected_out_re.append('')
expected_out_re.extend([
@@ -303,17 +297,9 @@ class RunTestCases(unittest.TestCase):
self.assertEqual(1, return_code)
test_failure_output = [
- re.escape('Note: Google Test filter = Baz.Fail'),
- r'',
- ] + [
re.escape(l) for l in
- gtest_fake_base.get_test_output('Baz.Fail', True).splitlines()
- ] + [
- '',
+ gtest_fake_base.get_test_output_inner('Baz.Fail', True).splitlines()
] + [
- re.escape(l) for l in gtest_fake_base.get_footer(1, 1).splitlines()
- ] + [
- '',
'',
]
@@ -384,15 +370,10 @@ class RunTestCases(unittest.TestCase):
expected_out_re.append(
r'\[%d/\d\] \d\.\d\ds ' % (index + 1) + re.escape(name) + ' .+')
- expected_out_re.append(re.escape('Note: Google Test filter = ' + name))
- expected_out_re.append('')
expected_out_re.extend(
- re.escape(l) for l in
- gtest_fake_base.get_test_output(name, 'Fail' in name).splitlines())
- expected_out_re.append('')
- expected_out_re.extend(
- re.escape(l) for l in gtest_fake_base.get_footer(1, 1).splitlines())
- expected_out_re.append('')
+ re.escape(l)
+ for l in gtest_fake_base.get_test_output_inner(
+ name, 'Fail' in name).splitlines())
expected_out_re.append('')
expected_out_re.extend([
« no previous file with comments | « tests/gtest_fake/gtest_fake_base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698