Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297583004: make use of media_use_ffmpeg in BUILD.gn (Closed)

Created:
5 years, 4 months ago by Mostyn Bramley-Moore
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of media_use_ffmpeg in BUILD.gn Committed: https://crrev.com/2196a4693837eee143be5f225236ed666bd31744 Cr-Commit-Position: refs/heads/master@{#344525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M BUILD.gn View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297583004/1
5 years, 4 months ago (2015-08-20 14:10:07 UTC) #2
Mostyn Bramley-Moore
@brettw: another small gn fixup, resolves a TODO from Dirk's CL: https://codereview.chromium.org/1104213005
5 years, 4 months ago (2015-08-20 14:10:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 14:37:40 UTC) #6
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-20 15:21:27 UTC) #7
brettw
lgtm
5 years, 4 months ago (2015-08-20 16:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297583004/1
5 years, 4 months ago (2015-08-20 17:13:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 17:22:20 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:22:55 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2196a4693837eee143be5f225236ed666bd31744
Cr-Commit-Position: refs/heads/master@{#344525}

Powered by Google App Engine
This is Rietveld 408576698