Rework definitions of 'gn_all' and related targets.

Rework definitions of 'gn_all' and related targets.

The 'gn_all' target in src/BUILD.gn didn't actually build everything,
which could be confusing. This patch renames the target to 'both_gn_and_gyp'
which should make the intent clearer, and reworks the accompanyhing
targets in both the GN and GYP builds to match.

R=jam@chromium.org
BUG=

Committed: https://crrev.com/ddc17490a20df0ed22f96995d4f007c7b437d77f
Cr-Commit-Position: refs/heads/master@{#327411}

[Dirk Pranke, 2015-04-28 00:38:39]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2015-04-28 00:39:02]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-28 00:39:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104213005/20001

[commit-bot: I haz the power, 2015-04-28 00:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 00:46:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dirk Pranke, 2015-04-28 00:56:18]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-28 00:56:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104213005/40001

[commit-bot: I haz the power, 2015-04-28 01:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:04:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2015-04-28 01:19:06]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-28 01:19:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104213005/60001

[commit-bot: I haz the power, 2015-04-28 02:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 02:24:07]

Dry run: This issue passed the CQ dry run.

[jam, 2015-04-28 04:32:42]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[jam, 2015-04-28 04:32:42]

this seems good, thanks for fixing. i defer to brett

[brettw, 2015-04-28 19:26:10]

https://codereview.chromium.org/1104213005/diff/60001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1104213005/diff/60001/BUILD.gn#newcode707
BUILD.gn:707: group("gn_groups") {
I don't understand why this exists.

[Dirk Pranke, 2015-04-28 19:44:20]

On 2015/04/28 19:26:10, brettw wrote:
> https://codereview.chromium.org/1104213005/diff/60001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1104213005/diff/60001/BUILD.gn#newcode707
> BUILD.gn:707: group("gn_groups") {
> I don't understand why this exists.

The idea was that if you build 'gn_all', then building 'all' should do nothing.
However, in order for that to be true, you have to enumerate all of the actual
group targets. You want to break those out separately in order to ensure that
they don't pull in any real targets that aren't caught by 'both_gn_and_gyp' and
'gn_only'.

However, it turns out that the mojo templates create a bunch of random group
targets, and enumerating them all is a hassle. After thinking about this more
last night (after I uploaded the patch), I think listing all of the group
targets is more trouble than it's worth, and we can probably achieve the desired
result by just checking that 'all' does nothing but stamp files.

So I think I'll remove both this and the matching 'gyp_groups' target from
gn_migration.gypi.

[Dirk Pranke, 2015-04-28 22:44:38]

On 2015/04/28 19:44:20, Dirk Pranke wrote:
> So I think I'll remove both this and the matching 'gyp_groups' target from
> gn_migration.gypi.

Done. Brett, please take another look?

[brettw, 2015-04-28 23:02:30]

lgtm

[Dirk Pranke, 2015-04-28 23:02:48]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-04-28 23:07:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104213005/80001

[commit-bot: I haz the power, 2015-04-29 01:38:41]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-29 01:39:35]

Patchset 4 (id:??) landed as
https://crrev.com/ddc17490a20df0ed22f96995d4f007c7b437d77f
Cr-Commit-Position: refs/heads/master@{#327411}