Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297583002: Remove grab-bag includes of v8.h from several files. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-heap-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from several files. R=yangguo@chromium.org Committed: https://crrev.com/374a4da83e6f4e05d31640b23b5ca92f0bbf0586 Cr-Commit-Position: refs/heads/master@{#30172}

Patch Set 1 #

Patch Set 2 : Fix Windows compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -56 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/allocation-tracker.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/arguments.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-literal-reindexer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-numbering.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/bignum.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/bignum.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bignum-dtoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/bignum-dtoa.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/cached-powers.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compilation-dependencies.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compilation-dependencies.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/diy-fp.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/diy-fp.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/log-utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/modules.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/rewriter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/safepoint-table.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/strtod.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/strtod.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/utils.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/variables.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1288413002 Patch 20001

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-14 08:51:21 UTC) #1
Yang
On 2015/08/14 08:51:21, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-14 09:32:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297583002/20001
5 years, 4 months ago (2015-08-14 09:40:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 09:41:39 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 09:42:04 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/374a4da83e6f4e05d31640b23b5ca92f0bbf0586
Cr-Commit-Position: refs/heads/master@{#30172}

Powered by Google App Engine
This is Rietveld 408576698