Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1288413002: Make some foo.h headers usable without foo-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make some foo.h headers usable without foo-inl.h header. This CL is a pure refactoring that makes an empty compilation unit including just "foo.h" but not "foo-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. This realizes above state for "spaces.h" and "mark-compact.h". R=hpayer@chromium.org Committed: https://crrev.com/16f96fde6b935c5f9a9d031f5df9809a814242ce Cr-Commit-Position: refs/heads/master@{#30171}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -203 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -17 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 chunks +20 lines, -72 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +89 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 8 chunks +28 lines, -74 lines 0 comments Download
M src/heap/spaces-inl.h View 7 chunks +87 lines, -24 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Michael Starzinger
Hannes: PTAL. Mike: FYI.
5 years, 4 months ago (2015-08-13 16:32:16 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h#newcode208 src/heap/mark-compact.h:208: void DecrementLiveBytes(HeapObject* object); This method does not really belong ...
5 years, 4 months ago (2015-08-14 05:05:48 UTC) #4
Michael Starzinger
https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h File src/heap/mark-compact.h (right): https://codereview.chromium.org/1288413002/diff/1/src/heap/mark-compact.h#newcode208 src/heap/mark-compact.h:208: void DecrementLiveBytes(HeapObject* object); On 2015/08/14 05:05:48, Hannes Payer wrote: ...
5 years, 4 months ago (2015-08-14 07:56:23 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-14 08:26:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288413002/20001
5 years, 4 months ago (2015-08-14 08:46:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 08:48:16 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 08:48:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16f96fde6b935c5f9a9d031f5df9809a814242ce
Cr-Commit-Position: refs/heads/master@{#30171}

Powered by Google App Engine
This is Rietveld 408576698