Improve TransportSecurityState data storage.

chrome/browser/profiles/profile_io_data.cc

Index: chrome/browser/profiles/profile_io_data.cc
===================================================================
--- chrome/browser/profiles/profile_io_data.cc	(revision 186438)
+++ chrome/browser/profiles/profile_io_data.cc	(working copy)
@@ -672,9 +672,6 @@
       new TransportSecurityPersister(transport_security_state_.get(),
                                      profile_params_->path,
                                      is_incognito()));
-  const std::string& serialized =
-      command_line.GetSwitchValueASCII(switches::kHstsHosts);
-  transport_security_persister_.get()->DeserializeFromCommandLine(serialized);

[palmer, 2013/03/25 23:54:34]

I tried to get rid of this once before, and cevans got cranky. He has a blog
post documenting its use, FWIW.

[unsafe, 2013/03/26 01:42:22]

http://scarybeastsecurity.blogspot.com/2011/04/fiddling-with-chromiums-new-ce...

The example cmdline is broken - ("public_key_hashes" is the wrong name).  But
the return value is ignored (above), so anyone who tries it will have no idea.

I think exposing the internal format is a bad idea, exposing it without feedback
on whether it's working is even worse, and no one uses it anyways.

So I think it's a waste of effort to keep porting and maintaining, as TSS
evolves.

 
   // Take ownership over these parameters.
   cookie_settings_ = profile_params_->cookie_settings;