Improve TransportSecurityState data storage.

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 654 matching lines @@
           io_thread->net_log(),
           io_thread_globals->proxy_script_fetcher_context.get(),
           profile_params_->proxy_config_service.release(),
           command_line));
 
   transport_security_state_.reset(new net::TransportSecurityState());
   transport_security_persister_.reset(
       new TransportSecurityPersister(transport_security_state_.get(),
                                      profile_params_->path,
                                      is_incognito()));
-  const std::string& serialized =
-      command_line.GetSwitchValueASCII(switches::kHstsHosts);
-  transport_security_persister_.get()->DeserializeFromCommandLine(serialized);

[palmer, 2013/03/25 23:54:34]

I tried to get rid of this once before, and cevans got cranky. He has a blog
post documenting its use, FWIW.

[unsafe, 2013/03/26 01:42:22]

http://scarybeastsecurity.blogspot.com/2011/04/fiddling-with-chromiums-new-ce...

The example cmdline is broken - ("public_key_hashes" is the wrong name).  But
the return value is ignored (above), so anyone who tries it will have no idea.

I think exposing the internal format is a bad idea, exposing it without feedback
on whether it's working is even worse, and no one uses it anyways.

So I think it's a waste of effort to keep porting and maintaining, as TSS
evolves.

 
   // Take ownership over these parameters.
   cookie_settings_ = profile_params_->cookie_settings;
 #if defined(ENABLE_NOTIFICATIONS)
   notification_service_ = profile_params_->notification_service;
 #endif
   extension_info_map_ = profile_params_->extension_info_map;
 
   resource_context_->host_resolver_ = io_thread_globals->host_resolver.get();
   resource_context_->request_context_ = main_request_context_.get();
@@ skipping 154 matching lines @@
 void ProfileIOData::SetCookieSettingsForTesting(
     CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }
 
 void ProfileIOData::set_signin_names_for_testing(
     SigninNamesOnIOThread* signin_names) {
   signin_names_.reset(signin_names);
 }