Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297323002: Do not create scrollbars if the subtree is invisible. (Closed)

Created:
5 years, 4 months ago by Ian Vollick
Modified:
5 years, 4 months ago
Reviewers:
ajuma
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not create scrollbars if the subtree is invisible. BUG=514595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200866

Patch Set 1 #

Patch Set 2 : add layout test. #

Total comments: 1

Patch Set 3 : whoops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 348193002 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297323002/1
5 years, 4 months ago (2015-08-19 00:07:32 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 02:03:37 UTC) #4
Ian Vollick
5 years, 4 months ago (2015-08-19 23:03:10 UTC) #6
ajuma
lgtm https://codereview.chromium.org/1297323002/diff/20001/LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html File LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html (right): https://codereview.chromium.org/1297323002/diff/20001/LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html#newcode7 LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html:7: animation: boring 5s infinite; This line can be ...
5 years, 4 months ago (2015-08-19 23:24:59 UTC) #7
Ian Vollick
On 2015/08/19 23:24:59, ajuma wrote: > lgtm > > https://codereview.chromium.org/1297323002/diff/20001/LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html > File > LayoutTests/compositing/animation/hidden-animated-layer-should-not-have-scrollbars-expected.html > ...
5 years, 4 months ago (2015-08-19 23:33:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297323002/40001
5 years, 4 months ago (2015-08-20 00:01:01 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 00:58:38 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200866

Powered by Google App Engine
This is Rietveld 408576698