Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 348193002: Remove some dead scrolling paths and unused params (Closed)

Created:
6 years, 6 months ago by Ian Vollick
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Remove some dead scrolling paths and unused params didScrollRect turns out to be useless as do some scroll delta params, so I've deleted them. Note this patch depends on: https://codereview.chromium.org/347053005 BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176802

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -52 lines) Patch
M Source/core/frame/FrameView.cpp View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/HostWindow.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/scroll/ScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +3 lines, -12 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/web/WebPopupMenuImpl.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M public/web/WebPluginContainer.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M public/web/WebWidgetClient.h View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ian Vollick
https://codereview.chromium.org/348193002/diff/1/public/web/WebWidgetClient.h File public/web/WebWidgetClient.h (left): https://codereview.chromium.org/348193002/diff/1/public/web/WebWidgetClient.h#oldcode56 public/web/WebWidgetClient.h:56: virtual void didScrollRect(int dx, int dy, const WebRect& clipRect) ...
6 years, 6 months ago (2014-06-23 15:07:58 UTC) #1
abarth-chromium
LGTM
6 years, 6 months ago (2014-06-23 17:11:19 UTC) #2
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-23 22:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/348193002/20001
6 years, 6 months ago (2014-06-23 22:13:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-23 23:33:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 00:00:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/9998)
6 years, 6 months ago (2014-06-24 00:00:54 UTC) #7
Ian Vollick
The CQ bit was checked by vollick@chromium.org
6 years, 6 months ago (2014-06-24 00:24:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/348193002/40001
6 years, 6 months ago (2014-06-24 00:24:27 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-24 01:26:50 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 02:03:06 UTC) #11
Message was sent while issue was closed.
Change committed as 176802

Powered by Google App Engine
This is Rietveld 408576698