Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297193002: Move VariationsRegistrySyncerWin to ChromeVariationsServiceClient (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VariationsRegistrySyncerWin to ChromeVariationsServiceClient VariationsService will be componentized, but VariationsRegistrySyncerWin will remain in //chrome. This CL moves the latter to ChromeVariationsServiceClient per the approach outlined in crbug.com/516682. BUG=516682 TBR=thakis Committed: https://crrev.com/60a594e7ba8509ce054f8d201a67015a423fabe2 Cr-Commit-Position: refs/heads/master@{#345293}

Patch Set 1 #

Patch Set 2 : Fix build #

Patch Set 3 : Fix build harder #

Total comments: 4

Patch Set 4 : Response to review #

Total comments: 2

Patch Set 5 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 3 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.h View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 1 2 3 4 4 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M components/variations/variations_service_client.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1301903005 Patch 20001

Messages

Total messages: 16 (5 generated)
blundell
5 years, 4 months ago (2015-08-18 18:59:34 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/1297193002/diff/40001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/1297193002/diff/40001/chrome/browser/chrome_browser_main.cc#newcode1657 chrome/browser/chrome_browser_main.cc:1657: if (variations_service) { Nit: No {}s https://codereview.chromium.org/1297193002/diff/40001/chrome/browser/chrome_browser_main.cc#newcode1658 chrome/browser/chrome_browser_main.cc:1658: variations_service->PerformInitialStartup(); ...
5 years, 4 months ago (2015-08-24 16:36:31 UTC) #3
blundell
https://codereview.chromium.org/1297193002/diff/40001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/1297193002/diff/40001/chrome/browser/chrome_browser_main.cc#newcode1657 chrome/browser/chrome_browser_main.cc:1657: if (variations_service) { On 2015/08/24 16:36:31, Alexei Svitkine (OOO ...
5 years, 4 months ago (2015-08-24 18:32:08 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1297193002/diff/60001/chrome/browser/metrics/variations/variations_service.h File chrome/browser/metrics/variations/variations_service.h (right): https://codereview.chromium.org/1297193002/diff/60001/chrome/browser/metrics/variations/variations_service.h#newcode79 chrome/browser/metrics/variations/variations_service.h:79: // Performs initial startup tasks. Nit: Update comment.
5 years, 4 months ago (2015-08-24 18:53:03 UTC) #5
blundell
https://codereview.chromium.org/1297193002/diff/60001/chrome/browser/metrics/variations/variations_service.h File chrome/browser/metrics/variations/variations_service.h (right): https://codereview.chromium.org/1297193002/diff/60001/chrome/browser/metrics/variations/variations_service.h#newcode79 chrome/browser/metrics/variations/variations_service.h:79: // Performs initial startup tasks. On 2015/08/24 18:53:03, Alexei ...
5 years, 4 months ago (2015-08-25 07:47:50 UTC) #6
blundell
TBR=thakis for chrome_browser_main.cc
5 years, 4 months ago (2015-08-25 07:48:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297193002/80001
5 years, 4 months ago (2015-08-25 07:48:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103692)
5 years, 4 months ago (2015-08-25 08:42:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297193002/80001
5 years, 4 months ago (2015-08-25 09:05:49 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-25 09:59:57 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 10:00:45 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/60a594e7ba8509ce054f8d201a67015a423fabe2
Cr-Commit-Position: refs/heads/master@{#345293}

Powered by Google App Engine
This is Rietveld 408576698