Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 1297193002: Move VariationsRegistrySyncerWin to ChromeVariationsServiceClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.h
diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h
index bd48d65083f8b146a018f373e98c3b957684b1f9..cdb203225b98584553fd736a4be1b920b8d3f507 100644
--- a/chrome/browser/metrics/variations/variations_service.h
+++ b/chrome/browser/metrics/variations/variations_service.h
@@ -23,10 +23,6 @@
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
-#if defined(OS_WIN)
-#include "chrome/browser/metrics/variations/variations_registry_syncer_win.h"
-#endif
-
class PrefService;
class PrefRegistrySimple;
@@ -80,6 +76,9 @@ class VariationsService
// may not be created.
bool CreateTrialsFromSeed();
+ // Should be called before startup of the main message loop.
+ void PerformPreMainMessageLoopStartup();
+
// Calls FetchVariationsSeed once and repeats this periodically. See
// implementation for details on the period. Must be called after
// |CreateTrialsFromSeed|.
@@ -98,11 +97,6 @@ class VariationsService
// code to notify each service individually.
void OnAppEnterForeground();
-#if defined(OS_WIN)
- // Starts syncing Google Update Variation IDs with the registry.
- void StartGoogleUpdateRegistrySync();
-#endif
-
// Sets the value of the "restrict" URL param to the variations service that
// should be used for variation seed requests. This takes precedence over any
// value coming from policy prefs. This should be called prior to any calls
@@ -286,11 +280,6 @@ class VariationsService
// List of observers of the VariationsService.
base::ObserverList<Observer> observer_list_;
-#if defined(OS_WIN)
- // Helper that handles synchronizing Variations with the Registry.
- VariationsRegistrySyncer registry_syncer_;
-#endif
-
base::ThreadChecker thread_checker_;
base::WeakPtrFactory<VariationsService> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698