Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
index fe9a30cf64f3160a04cc123293931795a034d9a4..be1817c6e09073c1a98cdd562f58e6ee7c1957c0 100644
--- a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
+++ b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
@@ -183,7 +183,7 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {
private float mCameraPosition;
// Lock to allow multithreaded access to mCameraPosition.
- private Object mCameraPositionLock = new Object();
+ private final Object mCameraPositionLock = new Object();
mikecase (-- gone --) 2015/08/19 23:15:08 fyi, for lambroslambrou@chromium.org. I synced and
Lambros 2015/08/19 23:42:02 Sorry for the noise - we're actively working on th
private float[] mCameraMatrix;
private float[] mViewMatrix;
@@ -228,11 +228,11 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {
private boolean mReloadTexture;
/** Lock to allow multithreaded access to mReloadTexture. */
- private Object mReloadTextureLock = new Object();
+ private final Object mReloadTextureLock = new Object();
// Lock for eye position related operations.
// This protects access to mEyePositionVector as well as mDesktop{Height/Width}Pixels.
- private Object mEyePositionLock = new Object();
+ private final Object mEyePositionLock = new Object();
private int mDesktopHeightPixels;
private int mDesktopWidthPixels;
@@ -244,7 +244,7 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {
private boolean mLoadSkyboxImagesTexture;
// Lock to allow multithreaded access to mLoadSkyboxImagesTexture.
- private Object mLoadSkyboxImagesTextureLock = new Object();
+ private final Object mLoadSkyboxImagesTextureLock = new Object();
private ChromotingDownloadManager mDownloadManager;

Powered by Google App Engine
This is Rietveld 408576698